Accept any HTTP status between 100 and 199 as benign
ClosedPublic

Authored by leinir on Mar 27 2019, 11:11 AM.

Details

Summary

In December 2017, a new status code (103) was added to the HTTP standard, and as one prominent OCS provider now uses this status code, Attica needs to be able to handle it more gracefully than just reporting an unknown OCS error (which is reported to the user, but has no actual effect on things). As it is a benign status, we simply accept it and forward it to the consumer as being not an error. Specifically, we do this by changing from accepting only status 100 as an informational status, to accepting any informational status (since any actual errors are reported through other status codes).

Diff Detail

Repository
R235 Attica
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Mar 27 2019, 11:11 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 27 2019, 11:11 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Mar 27 2019, 11:11 AM
apol added a subscriber: apol.Mar 27 2019, 12:02 PM

And why are 101 and 102 bad?
Should we just accept between 100 and 200?

In D20077#439290, @apol wrote:

And why are 101 and 102 bad?
Should we just accept between 100 and 200?

Hmm... You're probably right, yes, 100 is supposed to be all benign status type stuff, so... yeah, i'll do a quick update with that instead.

leinir updated this revision to Diff 54928.Mar 27 2019, 12:12 PM
leinir retitled this revision from Accept HTTP status 103 as benign to Accept any HTTP status between 100 and 199 as benign.
leinir edited the summary of this revision. (Show Details)

Just accept any informational status as benign, rather than the specifically picked ones.

ngraham accepted this revision.Mar 27 2019, 4:56 PM
This revision is now accepted and ready to land.Mar 27 2019, 4:56 PM
This revision was automatically updated to reflect the committed changes.