Add support for extracting data from ogg and ts files
ClosedPublic

Authored by astippich on Mar 24 2019, 4:10 PM.

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Mar 24 2019, 4:10 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 24 2019, 4:10 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Mar 24 2019, 4:10 PM
bruns added a comment.Mar 24 2019, 4:25 PM

According to ffplay, the ogg file has title and the like, so it should be listed in the MetaData test.

For reasons unknown, the metadata is not correctly extracted and "title" is not found for ogg videos, that's why it is not included there. I would like to investigate this later.

bruns added a comment.Mar 24 2019, 6:20 PM

For reasons unknown, the metadata is not correctly extracted and "title" is not found for ogg videos, that's why it is not included there. I would like to investigate this later.

Can you add it nevertheless, and mark it with a QEXPECT_FAIL, using an extra "expectFail" column?

What I meant is that no metadata is currently extracted at all. Is it possible to mark a complete test row as expected failure?

bruns added a comment.Mar 24 2019, 7:07 PM

What I meant is that no metadata is currently extracted at all. Is it possible to mark a complete test row as expected failure?

QEXPECT_FAIL("Vorbis Video", "Not yet supported", Abort) before the first QCOMPARE should work

astippich updated this revision to Diff 54725.Mar 24 2019, 7:51 PM
  • Add failing ogg video test case

forgot rebasing...

astippich updated this revision to Diff 54726.Mar 24 2019, 7:53 PM
  • Add failing ogg video test case
bruns accepted this revision.Mar 24 2019, 9:45 PM
This revision is now accepted and ready to land.Mar 24 2019, 9:45 PM
This revision was automatically updated to reflect the committed changes.