Details
Details
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| autotests/ffmpegextractortest.h | ||
|---|---|---|
| 32 | What is metadata data? :p | |
Comment Actions
Can you rename the videoTest(), so it is clear one is about intrinsic video properties, and the other about explicit information stored in tags/metadata bitstreams? Also add a comment saying so.
| autotests/ffmpegextractortest.h | ||
|---|---|---|
| 32 | Data for testing metadata ;-) | |
Comment Actions
..., otherwise, LGTM
| autotests/ffmpegextractortest.cpp | ||
|---|---|---|
| 53–54 | a little bit to much "test" here ;) | |