Differential D19961

Properly fix copy constructor
ClosedPublic
Actions

Authored by bruns on Mar 22 2019, 2:07 AM.

Details

Reviewers
ngraham
poboiko
Group Reviewers
Baloo
Frameworks
Commits
R293:ccb9b19e1e74: Properly fix copy constructor
Summary

Instead of printing a warning (which probably nobody would notice) just
fix the code, i.e. copy the private.

Test Plan

ctest

Diff Detail

Repository
R293 Baloo
Branch
fix_copy_constructor
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9960
Build 9978: arc lint + arc unit
bruns created this revision.Mar 22 2019, 2:07 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 22 2019, 2:07 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Mar 22 2019, 2:07 AM
ngraham accepted this revision.Mar 22 2019, 11:27 AM
This revision is now accepted and ready to land.Mar 22 2019, 11:27 AM
Closed by commit R293:ccb9b19e1e74: Properly fix copy constructor (authored by bruns). · Explain WhyMar 22 2019, 4:17 PM
This revision was automatically updated to reflect the committed changes.
davidedmundson added a subscriber: davidedmundson.Mar 22 2019, 7:58 PM
davidedmundson added inline comments.
src/lib/resultiterator.cpp
53

why not pos?

Revision Contents
Changeset List

PathPackages
Msrc/lib/resultiterator.cpp (4 lines)

Diff 54525

View Options

src/lib/resultiterator.cpp

Loading...