Improve consistency of window-* and add more
ClosedPublic

Authored by ndavis on Mar 9 2019, 2:35 PM.

Details

Summary

Add window-keep-above/below

Add window-maximize/restore/minimize

Change window-pin to titlebar button style

Make window-close more consistent

FEATURE: 405195

FIXED-IN: 5.57

Test Plan

Before

Breeze:

Breeze Dark:

After

Breeze:

Breeze Dark:

Diff Detail

Repository
R266 Breeze Icons
Branch
window-states (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9420
Build 9438: arc lint + arc unit
ndavis created this revision.Mar 9 2019, 2:35 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 9 2019, 2:35 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Mar 9 2019, 2:35 PM
ndavis edited the test plan for this revision. (Show Details)Mar 9 2019, 2:42 PM
ndavis updated this revision to Diff 53516.Mar 9 2019, 3:02 PM
ndavis edited the test plan for this revision. (Show Details)

Rename window-maximized to window-restore for better 3rd party compatibility

ndavis edited the summary of this revision. (Show Details)Mar 9 2019, 3:17 PM
ngraham added a subscriber: ngraham.Mar 9 2019, 4:34 PM

Neat! Very helpful, thanks.

While you're at it, do you think you could add a window-unpin icon too? https://bugs.kde.org/show_bug.cgi?id=405195

Also window-shade?

ndavis added a comment.Mar 9 2019, 5:07 PM

Neat! Very helpful, thanks.

While you're at it, do you think you could add a window-unpin icon too? https://bugs.kde.org/show_bug.cgi?id=405195

Yes, but I'm not sure if it should copy the style of the unpin button from the tilebar or if it should have a line through it like you suggested. I feel like the line is more clear, but less consistent. Maybe it's the titlebar button unpin that should be changed?

Also window-shade?

That can be done once D19575 and D19638 are landed.

Neat! Very helpful, thanks.

While you're at it, do you think you could add a window-unpin icon too? https://bugs.kde.org/show_bug.cgi?id=405195

Yes, but I'm not sure if it should copy the style of the unpin button from the tilebar or if it should have a line through it like you suggested. I feel like the line is more clear, but less consistent. Maybe it's the titlebar button unpin that should be changed?

Yeah, I kinda think the titlebar icon should look more like a toggle action such that a pinned window just gets a background circle and the symbol inverts. Regardless, we'd need a different style anyway for the proposed window-unpin icon since it's going to be used for a menu action where the title literally is "Unpin from Task Manager."

ndavis updated this revision to Diff 53569.Mar 10 2019, 6:56 AM
  • Add window-unpin
ndavis edited the test plan for this revision. (Show Details)Mar 10 2019, 7:00 AM
ndavis edited the test plan for this revision. (Show Details)
ndavis updated this revision to Diff 53571.Mar 10 2019, 7:17 AM
  • Add window-unpin-symbolic
ndavis edited the summary of this revision. (Show Details)Mar 10 2019, 7:21 AM
ngraham accepted this revision.Mar 10 2019, 4:05 PM

Thanks!

This revision is now accepted and ready to land.Mar 10 2019, 4:05 PM

window-shade can be added in a later patch so that this one isn't unnecessarily held back

This revision was automatically updated to reflect the committed changes.