Differential D1963

Guarding the X11 calls not to appear in a wayland session
ClosedPublic
Actions

Authored by ivan on Jun 20 2016, 3:34 PM.

Details

Reviewers
sebas
bshah
graesslin
Commits
R119:7a0522ca224b: Guarding the X11 calls not to appear in a wayland session
Summary

All x11 methods got the x11_ prefix to be more obvious which parts
are x11-only. Added default implementation for wayland sessions, and
a note that activity switching using keyboard is a regression compared to x11

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ivan updated this revision to Diff 4645.Jun 20 2016, 3:34 PM
ivan retitled this revision from to Guaring the X11 calls not to appear in a wayland session.
ivan updated this object.
ivan edited the test plan for this revision. (Show Details)
ivan added reviewers: sebas, graesslin, bshah.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 20 2016, 3:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn added a subscriber: gladhorn.Jun 20 2016, 4:03 PM

Guaring seems like a typo to me.

bshah added inline comments.Jun 20 2016, 4:04 PM
imports/activitymanager/switcherbackend.cpp
203–211

cache this value, as it is string comparison and impossible to change at runtime.

ivan updated this revision to Diff 4649.Jun 20 2016, 6:25 PM

Caching the value for 'are we on X11'

ivan marked an inline comment as done.Jun 20 2016, 6:26 PM
ivan added inline comments.
imports/activitymanager/switcherbackend.cpp
203–211

Anyone asked Qt guys whether they would like this cached in Qt?

ivan retitled this revision from Guaring the X11 calls not to appear in a wayland session to Guarding the X11 calls not to appear in a wayland session.Jun 20 2016, 6:28 PM
ivan marked an inline comment as done.
In D1963#36110, @gladhorn wrote:

Guaring seems like a typo to me.

Yes, thanks!

bshah accepted this revision.Jun 21 2016, 12:56 PM
bshah edited edge metadata.

+1

This revision is now accepted and ready to land.Jun 21 2016, 12:56 PM
Closed by commit R119:7a0522ca224b: Guarding the X11 calls not to appear in a wayland session (authored by ivan). · Explain WhyJun 21 2016, 5:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4663

View Options

imports/activitymanager/switcherbackend.cpp

Loading...