compile without foreach
Details
Details
Diff Detail
Diff Detail
- Repository
- R289 KNotifications
- Branch
- compile_without_foreach (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9208 Build 9226: arc lint + arc unit
src/knotifyconfig.cpp | ||
---|---|---|
53 | How we can use iterator here ? |
src/notifybypopup.cpp | ||
---|---|---|
426 | this loop now will run forever... |
Comment Actions
This sadly breaks build with at least older versions of Phonon, as they have foreach loop in their public headers.
So this either needs a bump of the current
find_package(Phonon4Qt5 4.6.60 NO_MODULE)
or adding the QT_NO_FOREACH only if a newer working Phonon version is found.
Update: or removing the flag around the includes of Phonon for more hackery :)
Comment Actions
For the record, Laurent commented out the QT_NO_FOREACH define in commit cdfaff8ce6aa359555d0b611f9141d2012ec9dde, so the build should be fixed again.