Differential D19504

Extend KHtmlView::print() to use a predefined QPrinter instance
ClosedPublic
Actions

Authored by habacker on Mar 4 2019, 8:41 AM.

Details

Reviewers

dfaure
vkrause

Commits

R313:2d8cba050729: Extend KHtmlView::print() to use a predefined QPrinter instance

Summary

This is required to share printer settings inside an application.

BUG:405011

Test Plan

compile on linux

Diff Detail

Repository

R313 KHtml

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

habacker created this revision.Mar 4 2019, 8:41 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 4 2019, 8:41 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

habacker requested review of this revision.Mar 4 2019, 8:41 AM

Harbormaster completed remote builds in B9146: Diff 53104.Mar 4 2019, 8:41 AM

tbaumgart added a subscriber: tbaumgart.Mar 6 2019, 1:32 PM

tbaumgart added inline comments.

src/khtmlview.cpp
3140	Why don't you pass a reference to the QPrinter object here?

habacker marked an inline comment as done.Mar 6 2019, 4:54 PM

habacker added inline comments.

src/khtmlview.cpp
3140	Because api dealing with QPrinter always use a pointer. void QWebView::print(QPrinter ) void QPrintPreviewDialog::paintRequested(QPrinter printer) QPrintPreviewDialog(QPrinter printer, QWidget parent = nullptr, Qt::WindowFlags flags = Qt::WindowFlags() QPrintDialog(QPrinter * printer, QWidget * parent = 0) QPageSetupDialog(QPrinter printer, QWidget parent) QPrintPreviewWidget(QPrinter printer, QWidget parent, Qt::WindowFlags flags)

The code is fine, the bigger question here is if we want new features in khtml that is part of the "portingAids" part of frameworks.

src/khtmlview.h
216	Needs a @since marker.

added @since tag

The patch was added to build the stable version of KMyMoney
for Windows to fix an issue not been able to have common
printer settings. Since KHTML is the successor of kdelilbs,
it has been ported to KF5.

Harbormaster completed remote builds in B9266: Diff 53327.Mar 7 2019, 12:37 AM

habacker marked 2 inline comments as done.Mar 7 2019, 12:39 AM

ping ?

Another attempt after 9 minor releases have elapsed.

Harbormaster completed remote builds in B17676: Diff 67894.Oct 14 2019, 11:30 AM

ahmadsamir added reviewers: dfaure, vkrause.Oct 14 2019, 11:40 AM

dfaure accepted this revision.Oct 15 2019, 6:41 AM

This revision is now accepted and ready to land.Oct 15 2019, 6:41 AM

Closed by commit R313:2d8cba050729: Extend KHtmlView::print() to use a predefined QPrinter instance (authored by habacker). · Explain WhyOct 21 2019, 7:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/khtmlview.h (10 lines)
M			src/khtmlview.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	53104	06de271		Mar 4 2019, 8:41 AM	★	★
Diff 2	53327	06de271	- added @since tag	Mar 7 2019, 12:37 AM	★	★
Diff 3	67894	341f045	- Another attempt after 9 minor releases have elapsed.	Oct 14 2019, 11:30 AM	★	★
Diff 4	68479	341f045	R313:2d8cba0507291991c2421963ff23fbba65604e43	Oct 21 2019, 7:12 PM	★	★

Extend KHtmlView::print() to use a predefined QPrinter instanceClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 68479

src/khtmlview.h

src/khtmlview.cpp

Extend KHtmlView::print() to use a predefined QPrinter instance
ClosedPublic
Actions

Revision Contents
Changeset List