Present Windows effect: remove label 'Filter' when filtering windows
Needs ReviewPublic

Authored by leandrosantiago on Mar 2 2019, 1:54 PM.

Details

Reviewers
None
Group Reviewers
VDG
KWin
Summary

It is just ugly :-)

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9087
Build 9105: arc lint + arc unit
leandrosantiago created this revision.Mar 2 2019, 1:54 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 2 2019, 1:54 PM
leandrosantiago requested review of this revision.Mar 2 2019, 1:54 PM
ngraham edited reviewers, added: VDG, KWin; removed: kwin.Mar 2 2019, 2:06 PM
Restricted Application added a subscriber: kwin. · View Herald TranscriptMar 2 2019, 2:06 PM

I'd rather my product was easily used and ugly than beautiful and unclear.

I think it does need something to indicate what's happening if you randomly press a key.

A small search icon to the left of the text might suffice.

I'd rather my product was easily used and ugly than beautiful and unclear.

I think it does need something to indicate what's happening if you randomly press a key.

A small search icon to the left of the text might suffice.

Hi David, I personally like the minimalist approach of the present windows effect (it is in fact my main windows switching tool and the main reason I am not able to migrate to other window managers), and think that having an icon or explicit indicator about the filtering does not really help the user to understand what's going on.

As soon as one types - accidentally or not - , it gets obvious what's going on in the same way, the windows title overlay has no information indicating that that string is the windows title. It is just obvious (or it should be :-)).

Removing the "Filter" label also makes the visual way cleaner and I believe more efficient for those who rely on it (well, I can tell by myself :-)).

Cheers,
Leandro

zzag added a subscriber: zzag.Mar 4 2019, 10:33 AM

Generally speaking, PW is feature frozen, we only fix bugs.

ngraham added a subscriber: ngraham.Mar 4 2019, 2:38 PM
In D19474#424272, @zzag wrote:

Generally speaking, PW is feature frozen, we only fix bugs.

When will the freeze be lifted?

zzag added a comment.Mar 4 2019, 6:06 PM

When will the freeze be lifted?

I guess it won't be lifted; though I'd like to point out that I won't stand against this change.

In general, I think if we freeze the code for new features, we need to have a concrete plan for lifting the freeze that involves a rewrite or refactor, port to a different API, replacement with something better, etc. Otherwise we're just saying that we want this effect effect and its code to stagnate forever, which seems unfair to both users and developers.