Deleting arbitrary imaging sequence in the Capture module corrected.
ClosedPublic

Authored by wreissenberger on Feb 28 2019, 5:20 PM.

Details

Summary

Currently, when marking a single row and pressing the delete button, always the first row gets deleted and not the selected one.

As a fix, I created a new public slot removeJobFromQueue(), since removeJob(int) is always invoked with index=0 when the delete button is pushed. Maybe there is a more elegant way, but it seems like the slot obtains an (empty) argument when invoked through the push button event instead of none, which would lead to index=-1 as defined in the header file.

Test Plan

Open the Capture module and create multiple imaging rows. Try to delete any of them and check, whether the correct one disappears.

Diff Detail

Repository
R321 KStars
Branch
capture_delete_row
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8997
Build 9015: arc lint + arc unit
wreissenberger created this revision.Feb 28 2019, 5:20 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFeb 28 2019, 5:20 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Feb 28 2019, 5:20 PM
wreissenberger edited the summary of this revision. (Show Details)Feb 28 2019, 5:26 PM
TallFurryMan accepted this revision.Feb 28 2019, 5:33 PM

Good point! Would you care to make the whole line selected too in an additional diff? Right now the selection is per cell, which is confusing.

This revision is now accepted and ready to land.Feb 28 2019, 5:33 PM
mutlaqja accepted this revision.Feb 28 2019, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Good point! Would you care to make the whole line selected too in an additional diff? Right now the selection is per cell, which is confusing.

Sure, it's in D19429.