Differential D19429

Selection of rows in Capture instead of single cells
ClosedPublic
Actions

Authored by wreissenberger on Feb 28 2019, 9:45 PM.

Details

Reviewers
mutlaqja
TallFurryMan
Summary

Bug fix correcting the selection of entire rows in Capture. Additionally, if a row entry is deleted, the selection keeps its position.

Test Plan

Open Capture and create multiple capture sequence entries. Select one and observe, that the entire row is highlighted. Then press the Delete button and observe, that the selection remains in the same position.

Diff Detail

Repository
R321 KStars
Branch
capture_row_selection
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9025
Build 9043: arc lint + arc unit
wreissenberger created this revision.Feb 28 2019, 9:45 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFeb 28 2019, 9:45 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Feb 28 2019, 9:45 PM
TallFurryMan requested changes to this revision.Mar 1 2019, 5:54 AM

Looks good except for the unrelated changes.

kstars/ekos/capture/capture.ui
10

Unrelated change (I see this too and wonder why it's modified).

1738

Unrelated change

This revision now requires changes to proceed.Mar 1 2019, 5:54 AM
wreissenberger edited the test plan for this revision. (Show Details)Mar 1 2019, 6:23 AM
mutlaqja added a comment.Mar 1 2019, 10:07 AM

I've already included the changes in the committed version.

wreissenberger updated this revision to Diff 52904.Mar 1 2019, 3:34 PM

Side effects removed.

wreissenberger marked 2 inline comments as done.Mar 1 2019, 3:35 PM
TallFurryMan accepted this revision.Mar 1 2019, 3:36 PM
This revision is now accepted and ready to land.Mar 1 2019, 3:36 PM
wreissenberger added a comment.EditedMar 1 2019, 5:30 PM
In D19429#422370, @mutlaqja wrote:

I've already included the changes in the committed version.

Did you intentionally leave out the changes of capture.cpp?

mutlaqja added a comment.Mar 1 2019, 5:49 PM

I'm sorry, I applied the changes and I applied the singlerow selection myself. If there are still issues, open a new differential to track it.

wreissenberger added a comment.Mar 1 2019, 9:47 PM

Posted the remaining in D19456.

Revision Contents
Changeset List

Diff 52904

View Options

kstars/ekos/capture/capture.cpp

Loading...
View Options

kstars/ekos/capture/capture.ui

Loading...