You can run the tests with ctest while in the build directory (or the source directory, if you did an in-source build (boo!)).

The general approach seems reasonable, but just complicated by the fact that the dialog's content is provided by something in baloo-widgets. Dolphin is the only client of that, so in the long term I would support moving it back into Dolphin.

Anyway, that's up to the Dolphin folks. :) Thanks for the patch!

FWIW I don't think you need to add a max height since you're using SizeHint, and Qt takes care of that automatically by not allowing it to be taller than the screen is.

In D19241#419117, @meven wrote:

Correctly position context menu under wayland with a secondary screen

I wanted to put those changes in another review.
I am not familiar arc / phabricator usage hence this error, I wish to undo it.
I am going to have a look at the documentation.

The last changes fix https://bugs.kde.org/show_bug.cgi?id=404799

Remove it manually from this revision, then create a new branch from Dolphin's git master and re-apply your changes there, and create a new revision.

In D19241#418209, @elvisangelaccio wrote:

Is the design of letting dialog choosing when to show up ok ?

Please don't, a QDialog is supposed to be shown by using show() or open(), it shouldn't open on its own.

Do you have an alternative design here : The dialog must be shown only after it's content has been asynchronously loaded.

The alternative I can see is to let the caller wait to display the dialog until it is ready the display signals it is ready.