BUG: 397590
Details
Diff Detail
- Repository
- R369 Yakuake
- Branch
- arcpatch-D19237
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9575 Build 9593: arc lint + arc unit
Hi there, thanks for your patch. I've added our Yakuake dev as a reviewer.
In the meantime could you format the commit message as described here (https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch)? Since this is a visual change it would also be good to see a before and after screenshot.
Looks great!
There's a small thing needed here: We need to add Qt::Svg as an explicit dependency, otherwise displaying SVG files only works by accident. But I can do that seperately if you don't want to expand the patch.
Do you have dev access or do you need help landing this?
Does this also fix the blurry button icons in preferences? See https://bugsfiles.kde.org/attachment.cgi?id=120181
The line mentioned by Nate in https://bugs.kde.org/show_bug.cgi?id=407726#c2 is not present.
@matthieugras sorry this got lost. Once it's ready to land I can land it for you. While we're at it, would you like to try fixing blurry hidpi buttons too? See the suggestion at https://bugs.kde.org/show_bug.cgi?id=407726#c2
I do not have commit access
Maybe you should get one, then you don't have to rely on others to commit.
Sorry this took so long @matthieugras! Since you've gotten several patches accepted now, please feel free to apply: https://techbase.kde.org/Contribute/Get_a_Contributor_Account