Differential D19134

Multiply radius by 0.5 in calculateBlurStdDev()
ClosedPublic
Actions

Authored by ndavis on Feb 18 2019, 10:06 PM.

Details

Reviewers
ngraham
Group Reviewers
Breeze
Commits
R31:cd04f42432a6: Multiply radius by 0.5 in calculateBlurStdDev()
Summary

Fix TODO to follow w3.org standard for shadow-blur

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Feb 18 2019, 10:06 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2019, 10:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Feb 18 2019, 10:06 PM
ndavis retitled this revision from Multiply radius by 0.5 in calculateBlurStdDev to Multiply radius by 0.5 in calculateBlurStdDev().Feb 18 2019, 10:06 PM
ngraham accepted this revision.Feb 18 2019, 10:35 PM
ngraham added a subscriber: ngraham.

Makes sense to do this while we're tweaking the appearance of the shadows for 5.16 anyway.

This revision is now accepted and ready to land.Feb 18 2019, 10:35 PM
Closed by commit R31:cd04f42432a6: Multiply radius by 0.5 in calculateBlurStdDev() (authored by ndavis). · Explain WhyFeb 18 2019, 10:35 PM
This revision was automatically updated to reflect the committed changes.
davidedmundson added a subscriber: davidedmundson.Feb 18 2019, 11:18 PM

so in order to not break existing shadow

So won't this break existing shadow parameters?

zzag added a subscriber: zzag.Feb 18 2019, 11:22 PM

Please revert this change.

ngraham added a comment.Feb 19 2019, 4:44 PM

Sorry, we had discussed this with @zzag in the VDG room and I (perhaps erroneously?) left with the impression that this was set at its previous value to preserve a certain look-and-feel, and was therefore something we could change since we were adjusting that look-and-feel elsewhere. I did test it and didn't notice any visual regressions.

Can you clarify what problems this change causes?

Revision Contents
Changeset List

Diff 52020

View Options

libbreezecommon/breezeboxshadowrenderer.cpp

Loading...