Add a test for ffmpeg extractor
ClosedPublic
Actions

Authored by astippich on Feb 17 2019, 7:26 PM.

Details

Reviewers

Commits

R286:f4c72f517911: Add a test for ffmpeg extractor

Summary

Test the ffmpegextractor using
a test file. The file contains 1 second
of blackness.

Repository

R286 KFileMetaData

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript

astippich requested review of this revision.Feb 17 2019, 7:26 PM

autotests/ffmpegextractortest.cpp
46	I find it somewhat difficult to grasp `Title` is KFileMetaData::Property::Title. You can use something like: namespace KFMProp = KFileMetaData::Property; ... ... value(KFMProp::Title).toString()

astippich marked an inline comment as done.Feb 18 2019, 6:54 PM

astippich added inline comments.

autotests/ffmpegextractortest.cpp
46	In that case, just using Property::XXXXX is probably best

This revision is now accepted and ready to land.Feb 18 2019, 10:18 PM

This revision was automatically updated to reflect the committed changes.

astippich marked an inline comment as done.

			Path
M			autotests/CMakeLists.txt (11 lines)
A	M		autotests/ffmpegextractortest.h (35 lines)
A	M		autotests/ffmpegextractortest.cpp (53 lines)
A	M	(bin)	autotests/samplefiles/test.webm

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	51915	beea703		Feb 17 2019, 7:26 PM	★	★
Diff 2	51990	beea703	- emphasize test properties	Feb 18 2019, 6:46 PM	★	★
Diff 3	52101	36dafc3	R286:f4c72f517911f14436ec63153d3f8e30017ef89b	Feb 19 2019, 7:16 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d6d1a7aee257	d5c2bafcfcec	73f1b71baa58	Alexander Stippich	emphasize test properties	Feb 18 2019, 6:46 PM
73f1b71baa58	6ebcd4212235	beea7035aa36	Alexander Stippich	Add a test for ffmpeg extractor (Show More…)	Feb 16 2019, 11:23 AM