| cfeck | |
| elvisangelaccio |
| Dolphin | |
| Frameworks |
Word-wrap KMessageWidget text to prevent the window from being widened
when the text is very long.
CCBUG: 404232
Only CCBUG: because word wrap only works where QLabel detects a word boundary;
it will not wrap a string with no spaces or other word boundaries (e.g.
"aaaaaaaaaaaaaaaaaaaa...")
boundaries
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I would just remove the comment. The commit references the bug anyway, and a bug reference in the code is only helpful if the code is wrong, and someone wants to understand why.
Well, the code is not wrong but rather incomplete. :) Do you want me to remove the TODO: too?
Well, fix the TODO, and you can remove the comment ;)
I guess QLabel needs new API to set https://doc.qt.io/qt-5/qtextoption.html#WrapMode-enum
But those plans should be tracked elsewhere, not in source. IMHO. You or maintainer decides, not me.
@cfeck What if we use a KSqueezedTextLabel in KMessageWidget instead? That would mostly fix also the 'aaaaaaaaaaaa' case without requiring new API in QLabel.
Dolphin could simply call KStringHandler::*squeeze(), maybe only on the actual filepath, if squeezing is preferred to wrapping.
Yep, that works great. Did it in D19103: Middle-elide very long filenames in error strings.
We'll still need this because word-wrapping the message is also an improvement.