Add mime types for raw image formats to desktop file
ClosedPublic

Authored by volkov on Fri, Feb 8, 2:55 PM.

Details

Summary

... if built with KDcraw.

Diff Detail

Repository
R260 Gwenview
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8212
Build 8230: arc lint + arc unit
volkov created this revision.Fri, Feb 8, 2:55 PM
Restricted Application added a project: Gwenview. · View Herald TranscriptFri, Feb 8, 2:55 PM
volkov requested review of this revision.Fri, Feb 8, 2:55 PM
pino added a subscriber: pino.Sat, Feb 9, 2:06 PM

Please do not add the translations manually, as they are handled by scripty automatically.

ngraham added a subscriber: ngraham.Sat, Feb 9, 2:08 PM

Does Gwenview actually support all these file formats? If so, why can't we add their mimetypes to the pre-existing desktop file?

Gwenview supports these formats only when it is built with KDcraw.
I used the approach from okular: when okular is built with support for a set of formats, then a separate desktop file is installed for them.
And the added gwenviewApplication_raw.desktop contains translations because it is just a modified copy of org.kde.gwenview.desktop.

And the added gwenviewApplication_raw.desktop contains translations because it is just a modified copy of org.kde.gwenview.desktop.

It doesn't matter, you should remove them and let the automated system add them automatically.

ngraham requested changes to this revision.Mon, Feb 11, 2:52 PM
This revision now requires changes to proceed.Mon, Feb 11, 2:52 PM

Wouldn't it be better to add mime types to org.kde.gwenview.desktop during the build?
https://lxr.kde.org/ doesn't respond, so I can't find an example for now.

volkov updated this revision to Diff 51528.Tue, Feb 12, 5:30 PM

modify existing desktop file instead of installing a new one

volkov retitled this revision from Install desktop file for raw image formats to Add mime types for raw image formats to desktop file.Wed, Feb 13, 2:46 PM
volkov edited the summary of this revision. (Show Details)
ngraham accepted this revision.Mon, Feb 18, 2:43 PM
This revision is now accepted and ready to land.Mon, Feb 18, 2:43 PM
volkov closed this revision.Mon, Feb 18, 2:58 PM

Just noticed this: should similar support be added into gvpart.desktop too?