Differential D18852

Add mime types for raw image formats to desktop file
ClosedPublic
Actions

Authored by volkov on Feb 8 2019, 2:55 PM.

Details

Reviewers
ngraham
Group Reviewers
Gwenview
Commits
R260:7afa340f9bf9: Add mime types for raw image formats to desktop file
Summary

... if built with KDcraw.

Diff Detail

Repository
R260 Gwenview
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8212
Build 8230: arc lint + arc unit
volkov created this revision.Feb 8 2019, 2:55 PM
Restricted Application added a project: Gwenview. · View Herald TranscriptFeb 8 2019, 2:55 PM
volkov requested review of this revision.Feb 8 2019, 2:55 PM
pino added a subscriber: pino.Feb 9 2019, 2:06 PM

Please do not add the translations manually, as they are handled by scripty automatically.

ngraham added a subscriber: ngraham.Feb 9 2019, 2:08 PM

Does Gwenview actually support all these file formats? If so, why can't we add their mimetypes to the pre-existing desktop file?

volkov added a comment.Feb 11 2019, 10:52 AM

Gwenview supports these formats only when it is built with KDcraw.
I used the approach from okular: when okular is built with support for a set of formats, then a separate desktop file is installed for them.
And the added gwenviewApplication_raw.desktop contains translations because it is just a modified copy of org.kde.gwenview.desktop.

ngraham added a comment.Feb 11 2019, 2:51 PM
In D18852#409820, @volkov wrote:

And the added gwenviewApplication_raw.desktop contains translations because it is just a modified copy of org.kde.gwenview.desktop.

It doesn't matter, you should remove them and let the automated system add them automatically.

ngraham requested changes to this revision.Feb 11 2019, 2:52 PM
This revision now requires changes to proceed.Feb 11 2019, 2:52 PM
volkov added a comment.Feb 11 2019, 3:09 PM

Wouldn't it be better to add mime types to org.kde.gwenview.desktop during the build?
https://lxr.kde.org/ doesn't respond, so I can't find an example for now.

volkov updated this revision to Diff 51528.Feb 12 2019, 5:30 PM

modify existing desktop file instead of installing a new one

volkov retitled this revision from Install desktop file for raw image formats to Add mime types for raw image formats to desktop file.Feb 13 2019, 2:46 PM
volkov edited the summary of this revision. (Show Details)
ngraham accepted this revision.Feb 18 2019, 2:43 PM
This revision is now accepted and ready to land.Feb 18 2019, 2:43 PM
volkov closed this revision.Feb 18 2019, 2:58 PM
ngraham added a comment.Feb 18 2019, 4:28 PM

Just noticed this: should similar support be added into gvpart.desktop too?

Revision Contents
Changeset List

Diff 51528

View Options

app/CMakeLists.txt

Loading...
View Options

app/org.kde.gwenview.desktop

Loading...
View Options

app/org.kde.gwenview.desktop.cmake

Loading...