Change glowbar.svgz to smoother style
ClosedPublic

Authored by ndavis on Thu, Feb 7, 11:38 PM.

Details

Summary

The old style was weird. When the screen edge feature was enabled for the sides of screens, it looked like a bunch of dots smooshed together. Now it's one smooth bar.
BUG: 391343
FIXED-IN: 5.56

Test Plan

Before


After

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Thu, Feb 7, 11:38 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Feb 7, 11:38 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Thu, Feb 7, 11:38 PM

JFYI, the whole embedded stylesheet thing doesn't work on gradients, so it doesn't matter if colors are hardcoded.

ndavis edited the test plan for this revision. (Show Details)Fri, Feb 8, 12:06 AM
ndavis edited the test plan for this revision. (Show Details)
ndavis edited the test plan for this revision. (Show Details)Fri, Feb 8, 12:08 AM

This looks really good!
With this the bug 391343 will be fixed.

rooty added a subscriber: rooty.Fri, Feb 8, 12:15 AM

This looks really good!
With this the bug 391343 will be fixed.

I like it too, +1.
Can you also CC the BUG so it gets closed?

ndavis edited the summary of this revision. (Show Details)Fri, Feb 8, 12:15 AM

If you like it, don't be afraid to hit "Approve" ;)

rooty accepted this revision.Fri, Feb 8, 12:34 AM

Wait I can do that? I didn't know I could do that :D

This revision is now accepted and ready to land.Fri, Feb 8, 12:34 AM

Wait I can do that? I didn't know I could do that :D

Yes, but I should have said make sure you've given patches you want to approve a good look first. Use arc patch D<diff number here> so you can look at it on your own hard drive unless you're confident that no mistakes were made by looking at the code on Phabricator.

rooty added a comment.Fri, Feb 8, 12:41 AM

Sure thing. This seems straightforward enough to me though

ndavis edited the summary of this revision. (Show Details)Fri, Feb 8, 12:42 AM
ndavis edited the test plan for this revision. (Show Details)

For some reason, this version looks much larger in the corners. Was there a change to how the screen edge effect works? I didn't change the size of the corners in the SVGZ.

rooty added a comment.Fri, Feb 8, 12:50 AM

For some reason, this version looks much larger in the corners. Was there a change to how the screen edge effect works? I didn't change the size of the corners in the SVGZ.

This is the old version (kind of strange)
and this is yours, much better in my opinion...

ndavis added a comment.Fri, Feb 8, 1:10 AM

I suppose it's this, but it's somehow even worse with this patch: https://bugs.kde.org/show_bug.cgi?id=337712

I had a look through the Screen Edge effect code and while I'm no expert, I didn't see anything that would obviously make the corners large.

rooty added a comment.Fri, Feb 8, 1:37 AM

You could make it smaller? It looks fine to me at the corners, it's the actual sidebar that's a little thick.

I still like this diff though, I think that the master's too stippled/dotted.

ndavis added a comment.Fri, Feb 8, 2:46 AM

You could make it smaller? It looks fine to me at the corners, it's the actual sidebar that's a little thick.

I still like this diff though, I think that the master's too stippled/dotted.

I don't think I can change anything about the size in this patch. I think the sizes are determined elsewhere. Here's the real thickness of the portion of the image that is used for the top screen edge:

ndavis added a comment.Fri, Feb 8, 8:56 AM

Well, there's nothing wrong within the patch itself, so I'll land it.

This revision was automatically updated to reflect the committed changes.
zzag added a subscriber: zzag.Fri, Feb 8, 10:37 AM

I had a look through the Screen Edge effect code and while I'm no expert, I didn't see anything that would obviously make the corners large.

The screen edge effect scales corner tiles and I don't think this will be changed.

If slightly bigger corner glows is really such a big issue, then as a potential solution, the gradients could be "scaled" down a little bit.

zzag added a comment.Fri, Feb 8, 10:43 AM

Also, it's worth to mention glowbar from Oxygen theme (plasma-framework/src/desktoptheme/oxygen/widgets/glowbar.svgz).