The old style was weird. When the screen edge feature was enabled for the sides of screens, it looked like a bunch of dots smooshed together. Now it's one smooth bar.
BUG: 391343
FIXED-IN: 5.56
Details
- Reviewers
rooty - Group Reviewers
VDG - Commits
- R242:054b494bb3f2: Change glowbar.svgz to smoother style
Before
After
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
JFYI, the whole embedded stylesheet thing doesn't work on gradients, so it doesn't matter if colors are hardcoded.
Yes, but I should have said make sure you've given patches you want to approve a good look first. Use arc patch D<diff number here> so you can look at it on your own hard drive unless you're confident that no mistakes were made by looking at the code on Phabricator.
For some reason, this version looks much larger in the corners. Was there a change to how the screen edge effect works? I didn't change the size of the corners in the SVGZ.
and this is yours, much better in my opinion...
I suppose it's this, but it's somehow even worse with this patch: https://bugs.kde.org/show_bug.cgi?id=337712
I had a look through the Screen Edge effect code and while I'm no expert, I didn't see anything that would obviously make the corners large.
You could make it smaller? It looks fine to me at the corners, it's the actual sidebar that's a little thick.
I still like this diff though, I think that the master's too stippled/dotted.
I don't think I can change anything about the size in this patch. I think the sizes are determined elsewhere. Here's the real thickness of the portion of the image that is used for the top screen edge:
The screen edge effect scales corner tiles and I don't think this will be changed.
If slightly bigger corner glows is really such a big issue, then as a potential solution, the gradients could be "scaled" down a little bit.
Also, it's worth to mention glowbar from Oxygen theme (plasma-framework/src/desktoptheme/oxygen/widgets/glowbar.svgz).