Some icons didn't work because of assumptions I made about how fallback icons worked that were previously true. I have added additional symlinks and renamed some symlinks so that they work correctly.
Details
Details
- Reviewers
- None
- Group Reviewers
VDG - Commits
- R266:cff0b5794d82: Add and rename some YaST icons and symlinks
Before:
After:
Diff Detail
Diff Detail
- Repository
- R266 Breeze Icons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
General policy surrounding workarounds that are committed to the repo is that you need to know and mention the specific bug(s) you're working around.
Comment Actions
@fvogt LCP said a Qt bug was the reason that the icons weren't working correctly and that you would know more about it. I never got around to asking you though. Do you know which bug it is?
Comment Actions
I don't remember any bug with fallback names. The only one that is vaguely related is https://bugs.kde.org/show_bug.cgi?id=402172, but I doubt it's that one.
Comment Actions
It's not really a workaround, all of those icons are valid when it comes to YaST, however previous batch of YaST icons into Breeze was build on idea that icon xyz-abc.svg will fallback to xyz.svg inside the same icon theme. In QIcon::fromTheme that is the case IF icon xyz-abc.svg does not exist in hicolor or any other fallback theme.
Comment Actions
I think I'll just land this. It fixes a bug caused by my misunderstanding of how YaST currently works.