Diffusion KIO 4fb959b910bf

Show feedback inline when creating new files or folders

Authored by ngraham on Jun 19 2019, 4:09 PM.

Description

Show feedback inline when creating new files or folders

Summary:
Right now, the new file/folder dialog allows you to give it an invalid name, and
afterwards it will show you a dialog window complaining at you. This is not very
user-friendly, and becomes more user-unfriendly if we want to use it to show
warnings rather than errors. Finally it doesn't scale well because as we add more
conditions to check for, we'll need to add more dialog windows.

This patch implements the name feedback/warning/error inline in the original name
dialog itself, and disables the OK button for invalid names.

This patch obsoletes D18384, D18563, and D18599.

Test Plan:

Reviewers: VDG, Frameworks, shubham, filipf, meven

Reviewed By: VDG, filipf, meven

Subscribers: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D21907

Details

Committed
ngrahamJun 22 2019, 11:28 AM
Reviewer
VDG
Differential Revision
D21907: Show feedback inline when creating new files or folders
Parents
R241:11a14afc831e: Auth Support: Drop privileges if target is not owned by root
Branches
Unknown
Tags
Unknown