[Desktop Toolbox] Use "tools" icon
AbandonedPublic

Authored by ngraham on Jan 26 2019, 12:29 AM.

Details

Reviewers
None
Group Reviewers
VDG
Plasma
Summary

We have a toolbox icon now, which seems like the perfect thing for something called the "Desktop Toolbox"

Test Plan

In the corner:

On the top:

On its side:

Diff Detail

Repository
R119 Plasma Desktop
Branch
use-tools-icon-for-toolbox (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7541
Build 7559: arc lint + arc unit
ngraham created this revision.Jan 26 2019, 12:29 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 26 2019, 12:29 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 26 2019, 12:29 AM
ngraham edited the test plan for this revision. (Show Details)Jan 26 2019, 12:30 AM
ndavis added a subscriber: ndavis.Jan 26 2019, 2:09 AM

I'm not sure if the tools icon is actually appropriate here. I know it's called the Desktop Toolbox, but it doesn't work at all like the tools menus in Spectacle or KSysGuard. It's almost like a button to open the desktop context menu, except it also shows the controls for widgets. It doesn't seem like a menu for a set of tools.

hein added a subscriber: hein.Jan 26 2019, 7:31 AM

How about we actually rename it "Desktop Menu".

GB_2 added a subscriber: GB_2.Jan 26 2019, 7:57 AM
In D18546#400253, @hein wrote:

How about we actually rename it "Desktop Menu".

+1, good idea!

Codezela added a subscriber: Codezela.EditedJan 26 2019, 12:56 PM
In D18546#400256, @GB_2 wrote:
In D18546#400253, @hein wrote:

How about we actually rename it "Desktop Menu".

+1, good idea!

or we can remove it completely
it looks strange no one doing it except kde
what do u think
mac windows gnome cinnamon mate budgie
xfce lxqt
we can make this tools show with shortucut like
ctrl+ mouse click on the desktop for example
i think without it the desktop will look much simple and clean

In D18546#400256, @GB_2 wrote:
In D18546#400253, @hein wrote:

How about we actually rename it "Desktop Menu".

+1, good idea!

or we can remove it completely
it looks strange no one doing it except kde
what do u think
mac windows gnome cinnamon mate budgie
xfce lxqt
we can make this tools show with shortucut like
ctrl+ mouse click on the desktop for example
i think without it the desktop will look much simple and clean

I'm mostly for removing it. A common question new users ask is how to remove it.
However, the way we expose desktop widget controls is not the most intuitive or ergonomic for mouse & keyboard users. Long click is a mobile thing that isn't intuitive in the first place. We need a way to quickly expose the controls for desktop widgets in a way that is fairly discoverable. This is off topic though and this discussion should probably happen somewhere more permanent like a task.

If we are going to change the name, I would suggest changing it to something that has a similar meaning to "edit the desktop" and change the icon to something that means "edit". That's the primary use for this widget anyway.

I've started a Phab task to discuss the issue from a higher level: T10402: The Desktop Toolbox.

GB_2 added a comment.Apr 13 2019, 6:18 AM

I think this revision can be abandoned.

ngraham planned changes to this revision.Apr 13 2019, 1:40 PM
ngraham abandoned this revision.