A lot of methods that no one called, a lot of methods that the
only calee could be removed to a direct call.
Details
Details
- Reviewers
hindenburg ngraham - Group Reviewers
Konsole - Commits
- R319:392c7d0fcc52: Remove dead code in TerminalDisplay
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I've been wanting to refactor it to remove all the individual getters and setters in TerminalDisplay, and just let TerminalDisplay hold the Profile::Ptr, then terminaldisplay can just directly use the values from Profile instead of duplicating all the variables and getters/setters.
Comment Actions
I tough about that but it’s not that easy unless we also refactor the
Profile class, because everything in the profile class is stored inside a
map. It would be quite expensive to always access it.
Em sex, 8 de fev de 2019 às 20:56, Martin Tobias Holmedahl Sandsmark <
noreply@phabricator.kde.org> escreveu:
sandsmark added a comment. View Revision
https://phabricator.kde.org/D18520I've been wanting to refactor it to remove all the individual getters and
setters in TerminalDisplay, and just let TerminalDisplay hold the
Profile::Ptr, then terminaldisplay can just directly use the values from
Profile instead of duplicating all the variables and getters/setters.*REPOSITORY*
R319 Konsole*REVISION DETAIL*
https://phabricator.kde.org/D18520*To: *tcanabrava, Konsole, hindenburg, ngraham
*Cc: *sandsmark, konsole-devel, maciejn, thsurrel, ngraham,
maximilianocuria, hindenburg