Differential D18434

exiv2extractor: add support for bmp, gif, webp, tga
ClosedPublic
Actions

Authored by kossebau on Jan 21 2019, 6:38 PM.

Details

Reviewers
astippich
Group Reviewers
Baloo
Dolphin
Commits
R286:6bc922351db0: exiv2extractor: add support for bmp, gif, webp, tga
Summary

Gives only minimal info for bmp, gif & tga, but knowing the size
can be useful already.

exiv2 supports bmp, gif & tga since 0.17, so for all versions since
min required version 0.21. Webp is supported since 0.26.

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jan 21 2019, 6:38 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJan 21 2019, 6:38 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Jan 21 2019, 6:38 PM
aacid added a subscriber: aacid.Jan 25 2019, 9:28 PM

is it worth adding files to autotests/exiv2extractortest.cpp ?

kossebau added a comment.Jan 25 2019, 9:54 PM
In D18434#400106, @aacid wrote:

is it worth adding files to autotests/exiv2extractortest.cpp ?

Shortly considered, but then I saw so far only a jpg file is tested, and thinking about it, the test checks that using libexiv2 works in principle, going across all the formats would rather test libexiv2 and not really add anything.

astippich accepted this revision.Jan 27 2019, 1:19 PM
This revision is now accepted and ready to land.Jan 27 2019, 1:19 PM
Closed by commit R286:6bc922351db0: exiv2extractor: add support for bmp, gif, webp, tga (authored by kossebau). · Explain WhyJan 27 2019, 10:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50400

View Options

src/extractors/CMakeLists.txt

Loading...
View Options

src/extractors/exiv2extractor.cpp

Loading...