Add tools icon
ClosedPublic

Authored by ndavis on Jan 19 2019, 9:15 AM.

Details

Reviewers
GB_2
ngraham
Group Reviewers
VDG
Commits
R266:1000c8b4884e: Add tools icon
Summary

Adds a tools icon for menus that show a list of tools/programs (e.g., the "Tools" menus in Spectacle and KSysGuard)

FEATURE: 390285

Test Plan


Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Jan 19 2019, 9:15 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 19 2019, 9:15 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Jan 19 2019, 9:15 AM
ndavis edited the test plan for this revision. (Show Details)Jan 19 2019, 9:19 AM
ndavis edited the test plan for this revision. (Show Details)
ndavis edited the test plan for this revision. (Show Details)Jan 19 2019, 9:24 AM
ndavis updated this revision to Diff 49862.Jan 19 2019, 9:25 AM

Fix messed up breeze-dark 32px version

GB_2 accepted this revision.Jan 19 2019, 10:18 AM
GB_2 added a subscriber: GB_2.

Very nice!

This revision is now accepted and ready to land.Jan 19 2019, 10:18 AM

Very nice! Just what I had in mind. Do we really need a 32px version though? I thought we were trying to move towards all ≥ 32px icons being colorful, and not using the 32px size for action icons?

Very nice! Just what I had in mind. Do we really need a 32px version though?

A number of icons start with tools-, which means that this icon is the last fallback option. It could end up being seen in non-KDE apps, so I want to make sure I've covered my bases with the sizes.

I thought we were trying to move towards all ≥ 32px icons being colorful, and not using the 32px size for action icons?

I was not aware of us deciding not to use 32px for action icons. I'm not necessarily opposed to that idea, but it raises a number of questions about what to do with our own apps. For instance, should Okular start using color icons for its sidebar buttons when the icon size is set to Normal or Large and continue using monochrome icons for Small?

ngraham accepted this revision.Jan 19 2019, 2:49 PM

Very nice! Just what I had in mind. Do we really need a 32px version though?

A number of icons start with tools-, which means that this icon is the last fallback option. It could end up being seen in non-KDE apps, so I want to make sure I've covered my bases with the sizes.

Ah OK, that makes a lot of sense. +1

I thought we were trying to move towards all ≥ 32px icons being colorful, and not using the 32px size for action icons?

I was not aware of us deciding not to use 32px for action icons. I'm not necessarily opposed to that idea, but it raises a number of questions about what to do with our own apps. For instance, should Okular start using color icons for its sidebar buttons when the icon size is set to Normal or Large and continue using monochrome icons for Small?

Maybe it was just an informal conversation that I took too seriously. :) We can figure out later whether or not that's something we want to formally change (+1 on Okular using colorful icons for the large sizes though).

Ship it!

This revision was automatically updated to reflect the committed changes.