Since there are fancy "in view" messages which show all loading trouble,
is there no need to fetch and show some error message.
See also https://phabricator.kde.org/D18117
Details
Details
- Reviewers
cullmann dhaumann - Group Reviewers
KTextEditor - Commits
- R39:574b08d08111: Add TODO KF6 note
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
I have it only poor tested with our big S&R file, so no test was made with other trouble causing stuff.
This need a patch in Kate, will try to link that
KateBuffer::openFile
- There is no distingues from
- "create new file by command line" and
- "restore files of session"
- When..
- is the error wrong
- makes to me "new file" not much sense
Is there a way to check wat is going on, 1) or 2) ? Guess, yes, and you can point me
Comment Actions
- Don't set m_openingErrorMessage in KateBuffer::openFile
- m_openingErrorMessage is now nowhere set
Comment Actions
Just for info: If openingErrorMessage is indeed not set anymore, this is a behavior change, since KTextEditor::Document::openingErrorMessage() is public API. Looking at lxr.kde.org, it seems this is not used (but ->openingError() is used, see https://lxr.kde.org/source/kde/applications/kate/addons/filetree/katefiletreemodel.cpp#0554).
Comment Actions
I would not change that here, I would just ignore it in the application, as said in the other diff.
| src/include/ktexteditor/document.h | ||
|---|---|---|
| 394 ↗ | (On Diff #50759) | Hm, is it really that bool openingError() is not needed anymore? I thought this is about bool openingErrorMessage() that is not required anymore. |