Differential D17726

Add helper function to disable redirections (useful for kde-open)
ClosedPublic
Actions

Authored by achauvel on Dec 22 2018, 6:02 AM.

Details

Reviewers
dfaure
cfeck
Group Reviewers
Frameworks
Commits
R241:8c3f000b72ed: Add helper function to disable redirections (useful for kde-open)
Summary

See D15189

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
achauvel created this revision.Dec 22 2018, 6:02 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 22 2018, 6:02 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
achauvel requested review of this revision.Dec 22 2018, 6:02 AM
ngraham edited the summary of this revision. (Show Details)Dec 22 2018, 6:03 AM
ngraham added reviewers: dfaure, Frameworks, cfeck.
yurchor added a subscriber: yurchor.Dec 22 2018, 6:39 AM
yurchor added inline comments.
src/widgets/krun.h
158

Typo: wether -> whether

160

Typo: wether -> whether

dfaure requested changes to this revision.Dec 22 2018, 11:29 AM

Looks good otherwise.

src/widgets/krun.h
161

Missing @since 5.54

This revision now requires changes to proceed.Dec 22 2018, 11:29 AM
achauvel updated this revision to Diff 48028.Dec 22 2018, 8:14 PM
dfaure accepted this revision.Dec 22 2018, 10:59 PM
This revision is now accepted and ready to land.Dec 22 2018, 10:59 PM
Closed by commit R241:8c3f000b72ed: Add helper function to disable redirections (useful for kde-open) (authored by achauvel, committed by aacid). · Explain WhyJan 16 2019, 11:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/krun.h (8 lines)
Msrc/widgets/krun.cpp (10 lines)
Msrc/widgets/krun_p.h (1 line)

Diff 49677

View Options

src/widgets/krun.h

Loading...
View Options

src/widgets/krun.cpp

Loading...
View Options

src/widgets/krun_p.h

Loading...