Works.
Details
Details
- Reviewers
mart - Group Reviewers
Plasma - Commits
- R871:15172a6fc78d: [OSD] Allow disabling OSD through config file
R120:37ac27c59d97: [OSD] Allow disabling OSD through config file
R120:15172a6fc78d: [OSD] Allow disabling OSD through config file
R871:37ac27c59d97: [OSD] Allow disabling OSD through config file
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
can you explain why it should be configurable?
shell/osd.cpp | ||
---|---|---|
36 | sharing a lesson learned from KWin: if you dependency inject the KSharedConfig you get two advantages:
|
Comment Actions
this configuration is intended for kiosk setups?
if it's hidden, there is always the risk of bitrot
shell/shellcorona.cpp | ||
---|---|---|
224–227 | Is there no mechanism inside Plasma to notice when the config changes? |
shell/shellcorona.cpp | ||
---|---|---|
226 | KDirWatch::self() is a singleton consider the case where two things use the singleton, you use it to monitor ~/.plasmarc and another uses it to monitor /tmp/asdfadf this signal will be emitted in both cases. You should use the parameter in the signal to do some filtering. |