- Group Reviewers
- R120:37ac27c59d97: [OSD] Allow disabling OSD through config file
R120:15172a6fc78d: [OSD] Allow disabling OSD through config file
can you explain why it should be configurable?
sharing a lesson learned from KWin: if you dependency inject the KSharedConfig you get two advantages:
KDirWatch::self() is a singleton
consider the case where two things use the singleton, you use it to monitor ~/.plasmarc and another uses it to monitor /tmp/asdfadf this signal will be emitted in both cases. You should use the parameter in the signal to do some filtering.