Differential D17680

Port connect of subjob in copyNextFile to new connect syntax
ClosedPublic
Actions

Authored by broulik on Dec 19 2018, 9:29 AM.

Details

Reviewers
davidedmundson
dfaure
chinmoyr
Commits
R241:a4905c5994a7: Port connect of subjob in copyNextFile to new connect syntax
Test Plan

Copied files, total and processed size still correct.
Copied 1000 files, spent 1.32% of time in QMetaObjectPrivate::decodeMethodSignature
Both slots do more than just a couple of lines which is why I kept them as separate functions rather than putting their contents into the lambda

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 19 2018, 9:29 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 19 2018, 9:29 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Dec 19 2018, 9:29 AM
broulik edited the test plan for this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)Dec 19 2018, 9:41 AM
dfaure accepted this revision.Dec 19 2018, 7:23 PM
This revision is now accepted and ready to land.Dec 19 2018, 7:23 PM
Closed by commit R241:a4905c5994a7: Port connect of subjob in copyNextFile to new connect syntax (authored by broulik). · Explain WhyDec 20 2018, 7:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/copyjob.h (2 lines)
Msrc/core/copyjob.cpp (10 lines)

Diff 47873

View Options

src/core/copyjob.h

Loading...
View Options

src/core/copyjob.cpp

Loading...