NooOOOoOooOOoooooooo

Checking patch icons-dark/preferences/32/applications-internet.svg...
Checking patch dev/null => icons-dark/categories/32/applications-internet.svg...
error: dev/null: does not exist in index
Checking patch icons-dark/apps/48/internet-web-browser.svg...
Applied patch icons/preferences/32/preferences-web-browser-stylesheets.svg cleanly.

Any chance you could omit the symlink changes from this patch?

+1

In D17496#375658, @ngraham wrote:

Looks good visually, but the scalable test now fails:

$ grep -A 1 FAIL.*scalable Testing/Temporary/LastTest.log 
FAIL!  : ScalableTest::test_scalable(icons:Applications) The following icons are not available in a scalable directory:
  applications-internet
--
FAIL!  : ScalableTest::test_scalable(icons-dark:Applications) The following icons are not available in a scalable directory:
  applications-internet

This shouldn't be possible. categories/32 is a scalable directory according to `index.theme:

[categories/32]
Size=32
Context=Categories
Type=Scalable
MinSize=32
MaxSize=256

I did notice that symlinks for applications-internet exist in apps/16 and apps/22, so maybe there needs to be a scalable version in the same category? There was no apps/48/applications-internet, but there was a preferences/32/applications-internet. I removed that because it seemed redundant and out of place. Are applications able to specify which Context an icon they want to use comes from?

Now that this is landed, feel free to change the symlinks by hand.

The unittests fail, because of the duplicate:
https://build.kde.org/job/Frameworks/view/Everything%20-%20kf5-qt5/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/21/testReport/projectroot/autotests/dupe/

Can someone fix it?

According

In D17496#376605, @ngraham wrote:

Now that this is landed, feel free to change the symlinks by hand.

In D17496#386549, @dfaure wrote:

The unittests fail, because of the duplicate:
https://build.kde.org/job/Frameworks/view/Everything%20-%20kf5-qt5/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/21/testReport/projectroot/autotests/dupe/

Can someone fix it?

Fixed