[Device Notifier] Fix action button vertical alignment
ClosedPublic

Authored by thsurrel on Dec 7 2018, 10:36 PM.

Details

Test Plan

Before

After

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thsurrel created this revision.Dec 7 2018, 10:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 7 2018, 10:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
thsurrel requested review of this revision.Dec 7 2018, 10:36 PM
ngraham added inline comments.
applets/devicenotifier/package/contents/ui/DeviceItem.qml
308

- 2 looks like a magic number. Might that be better expressed as units.smallSpacing / 2 instead?

thsurrel updated this revision to Diff 47080.Dec 7 2018, 10:42 PM

No more magic :(

thsurrel marked an inline comment as done.Dec 7 2018, 10:42 PM
abetts added a subscriber: abetts.Dec 7 2018, 11:03 PM

Love it! +1

ngraham accepted this revision.Dec 8 2018, 3:45 AM

Works flawlessly! Very nice.

This revision is now accepted and ready to land.Dec 8 2018, 3:45 AM
This revision was automatically updated to reflect the committed changes.