Differential D17418

SearchView: Harmonize text in searchPlaceCombo
ClosedPublic
Actions

Authored by loh.tar on Dec 7 2018, 9:32 PM.

Details

Reviewers
sars
ngraham
dhaumann
Group Reviewers
Kate
VDG
Commits
R40:cec90e834e6d: SearchView: Harmonize text in searchPlaceCombo
Summary

Now all text starts with uppercase I. Reported as side note in

CCBUG: 389181

Test Plan

Before


After

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Dec 7 2018, 9:32 PM
Restricted Application added a project: Kate. · View Herald TranscriptDec 7 2018, 9:32 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Dec 7 2018, 9:32 PM
ngraham accepted this revision.Dec 7 2018, 9:35 PM
ngraham added a subscriber: ngraham.

Please add

BUG: 389181

To its own line in the Summary section. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

This revision is now accepted and ready to land.Dec 7 2018, 9:35 PM
dhaumann accepted this revision.Dec 7 2018, 9:41 PM
dhaumann added a subscriber: dhaumann.

Yes, looks good to me, thanks! These little things do mske a difference :)

loh.tar added a comment.Dec 7 2018, 10:21 PM

Please add

BUG: 389181

To its own line in the Summary section. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

I was about to do it, but after a short look there...

Either of these tags will cause that Bugzilla ticket to be automatically closed when the patch is committed.

... I think that's not correct. This patch fix not the main issue, only that extra hint.

@ngraham For my taste is the morphing "Next/Abort" button wrong. I would like to change it to a morphing "Search/Abort" button.

ngraham added a comment.Dec 7 2018, 10:23 PM
In D17418#372947, @loh.tar wrote:

Please add

BUG: 389181

To its own line in the Summary section. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

I was about to do it, but after a short look there...

Either of these tags will cause that Bugzilla ticket to be automatically closed when the patch is committed.

... I think that's not correct. This patch fix not the main issue, only that extra hint.

Then use:

CCBUG: 389181
loh.tar edited the summary of this revision. (Show Details)Dec 7 2018, 10:24 PM
Closed by commit R40:cec90e834e6d: SearchView: Harmonize text in searchPlaceCombo (authored by loh.tar, committed by sars). · Explain WhyDec 9 2018, 9:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Maddons/search/search.ui (4 lines)

Diff 47165

View Options

addons/search/search.ui

Loading...