Add flashlight action icons
ClosedPublic

Authored by trickyricky26 on Sun, Dec 2, 2:01 PM.

Details

Summary

FEATURE: 400879

FIXED-IN: 5.54

Add flashlight action icons in 16px, 22px, 24px and 32px.

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trickyricky26 created this revision.Sun, Dec 2, 2:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSun, Dec 2, 2:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
trickyricky26 requested review of this revision.Sun, Dec 2, 2:01 PM
trickyricky26 edited the summary of this revision. (Show Details)Sun, Dec 2, 2:03 PM
trickyricky26 edited the test plan for this revision. (Show Details)
trickyricky26 added a reviewer: VDG.
ngraham added a subscriber: ngraham.Sun, Dec 2, 7:28 PM

Looks pretty nice to me! I find myself wanting some little lines coming out of the top of the "on" version though. I guess that means we would need to add them as well for the "off" versions too though, and maybe that would look weird?

The main issue is that the added lines are too much complexity for 16px icons. They are probably possible for 22px and up, at the expense of making the flashlight look a bit short.

ndavis added a subscriber: ndavis.EditedMon, Dec 3, 12:38 AM

Reminds me of these: http://store.t-studious.com/wp-content/uploads/2016/12/Maglite-2D-LED-Torch-.jpg


I like the 32px version, but it kind of just looks like a tube with the 16px flashlight-off icon. What if you turned the head of the flashlight to the right? Then you'd have a bit more space since our HIG allows icons to go past the left and right margins sometimes. The battery icon we use in the Breeze Plasma theme does this. If you put the button on the top, then you might even be able to show the button without the red slash cutting it off.

The only issue with turning it to the right is that having the flashlight upright reflects the way the user would try to use it IRL. Point the phone and press the button.

trickyricky26 edited the summary of this revision. (Show Details)Mon, Dec 3, 6:08 AM

Do you think this style is better (16px versions shown):

ndavis added a comment.EditedMon, Dec 3, 10:06 PM

Do you think this style is better (16px versions shown):

I think so. It's more obvious that it's a flashlight in the off version.

I also like the horizontal one better.

Ok, will do when I have some time :)

There we go:

I think this looks quite nice and a bit clearer with the 16px icons as well. Will update the patch soon.

  • Switch to horizontal orientation for clarity
trickyricky26 edited the test plan for this revision. (Show Details)Wed, Dec 5, 3:54 PM
ngraham accepted this revision.Wed, Dec 5, 4:03 PM

I like it!

This revision is now accepted and ready to land.Wed, Dec 5, 4:03 PM
ndavis accepted this revision.Wed, Dec 5, 7:11 PM
This revision was automatically updated to reflect the committed changes.