Fixed Header in 3 plugins: Run Command, Multimedia control, Remote input
- Group Reviewers
- R225:12e6b2946160: Fixed Header in 3 plugin pages: Run Command, Multimedia control, Remote input
build the Android APK and analyze the Header in Run Command,
Remote input and Multimedia control plugins.
|55 ↗||(On Diff #46526)|
Can you say why a lot of methods are no longer throwing? Was it unnecessary to begin with? In any case, it would be best if that change (exceptions) were separated from this change (header fixing)
Looks good from this point of view. Thanks!
@nicolasfella, do you know whether changing the names of the strings in strings.xml will mess up the translators? If so, we should probably not touch those. It will make our code a little strange but it would save a lot of hassle on their end.
The thing I am woirred about is not the app having trouble, but I am worried this might cause trouble for the translation team. I don't know if they use the Android Studio translator. Since they also work on all of the other Qt projects in KDE, I expect that they might not.
I just don't know, and I would rather avoid risking a headache for them, since their job is already a hassle. If you would like to go ask them how their workflow looks and whether changing the names of already-translated strings will or will not cause a problem, I'm sure they would be happy to let you know!
It all depends on the deadlines. If the release date (which should be published on phabricator.kde.org/calendar or at least announced on kde-i18n-doc@ in advance, even if it's not precise) is not in one or two days, then it's fine to do changes.
The policy is different when a project maintain stable branches. In that case, an exception should be requested on kde-i18n-doc@ before touching strings in the stable branch. But I think it's not the case here.
That said, the translation strings are automatically extracted from the code every 24 hours, so please don't touch anything inside res/valus-<id>. Just change the code.
Sorry, this is going to feel like a tease. This is really good, and I'm sorry I'm so picky :)
Make sure to remove the now-unused strings from *just* strings.xml, not the translation files. For instance, the string "@string/remote_control" is no longer used