Differential D17044

Add FindExiv2.cmake to ECM
ClosedPublic
Actions

Authored by krop on Nov 20 2018, 11:42 AM.

Details

Reviewers
apol
dfaure
Summary

According to lxr, we have 8 copies of this module in different repositories (+kdelib4support and a playground repo).

Diff Detail

Repository
R240 Extra CMake Modules
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5176
Build 5194: arc lint + arc unit
krop created this revision.Nov 20 2018, 11:42 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptNov 20 2018, 11:42 AM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
krop requested review of this revision.Nov 20 2018, 11:42 AM
apol accepted this revision.Nov 20 2018, 12:14 PM

Looks good to me.

This revision is now accepted and ready to land.Nov 20 2018, 12:14 PM
krop closed this revision.Nov 20 2018, 12:28 PM
kossebau added a subscriber: kossebau.Nov 20 2018, 1:26 PM
kossebau added inline comments.
find-modules/FindExiv2.cmake
31

Could you not already do this now, before it's first released?

Any potential users currently have their own copy, they will not use this version.
Once they switch to rely on the version provided by ECM (and remove their own copy), they could also adapt the naming.
New users could use the new name from the beginning.

krop added inline comments.Nov 20 2018, 1:29 PM
find-modules/FindExiv2.cmake
31

I could of course :)

krop added a comment.Nov 20 2018, 1:44 PM

Done. kfilemetadata was also changed to use FindLibExiv2.cmake.

Revision Contents
Changeset List

Diff 45878

View Options

attic/modules/FindExiv2.cmake

Loading...
View Options

docs/find-module/FindExiv2.rst

Loading...
View Options

find-modules/FindExiv2.cmake

Loading...