...to ease the switch between dictionaries you usually need
CCBUG: 302689
ngraham | |
cullmann |
Frameworks | |
VDG |
...to ease the switch between dictionaries you usually need
CCBUG: 302689
Three shots how it looks in Kate
Normal size
Expaned to showcase the included splitter...
...and how the combobox looks
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
The added stuff at the ConfigWidget looks to me not perfect but OK. Suggestions are welcome. Some thoughts/questions
Bug302689 - Impossible to delete unwanted dictionaries
https://bugs.kde.org/show_bug.cgi?id=302689
Does not quite fit, but relieves the symptoms. Enough to close that?
I think this makes sense, it improves the usability of the dictionary selection.
I see no API issues, should be BC and docs are there, too.
Ah, one thing: Could you add some @since 5.xxx to the new function in speller.h? I assume 5.54 would be the right one.
Only in speller? In settings_p.h are also two new, but there was no docu, so I also wrote nothing, but could
I assume 5.54 would be the right one.
In CMake it's currently KF5_VERSION 5.53.0 so 5.54 is the right one?
I think only speller.h is installed as public API, yes.
I assume 5.54 would be the right one.
In CMake it's currently KF5_VERSION 5.53.0 so 5.54 is the right one?
I think so.
The intermediate diff looks strange, but the final diff is IMHO ok. Will apply that, thanks.