Add FileItemActionPlugin for tag manipulation

Authored by nicolasfella on Nov 13 2018, 11:43 PM.



Make it possible to add/remove tags from the context menu. It shows all known tags. Triggering an action adds/removes the appropriate tag. It also allows to create a new

Test Plan

Add tag to a file. Tag appears in context menu of all files. Add it to another file. Remove it again. Create new tag from context menu.

Diff Detail

R824 Baloo Widgets
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Nov 13 2018, 11:43 PM
Restricted Application added a project: Baloo. · View Herald TranscriptNov 13 2018, 11:43 PM
nicolasfella requested review of this revision.Nov 13 2018, 11:43 PM
  • Fix translations
  • Whitespace
nicolasfella edited the summary of this revision. (Show Details)Nov 13 2018, 11:48 PM
ngraham requested changes to this revision.Nov 14 2018, 2:41 PM


It should to be possible to show the context menu entry for folders, too, since they can also be tagged.


Can we change this to use an action verb?

Like "Assign Tags" or "Tag this Item" or something like that.


Needs to be in Title Case and have ellipses: "Create New..."

This revision now requires changes to proceed.Nov 14 2018, 2:41 PM
  • Show for directories
  • Use verb
  • Case and ellipsis
nicolasfella marked 2 inline comments as done.Nov 14 2018, 2:53 PM
nicolasfella edited the summary of this revision. (Show Details)Nov 14 2018, 2:58 PM
ngraham accepted this revision.Nov 14 2018, 3:14 PM

Thanks, looks great and works great!

This revision is now accepted and ready to land.Nov 14 2018, 3:14 PM
This revision was automatically updated to reflect the committed changes.

Shouldn't the plugin check whether the file is writable? I don't think we can add tags to root-owned files, do we?