Mobile text selection controls
ClosedPublic

Authored by mart on Nov 12 2018, 4:27 PM.

Details

Summary

in QQC2 the text selection controls depend upon the style, which has to
implement it by itself
this adds touch based draggable cursor and text selection handles,
alongside a tiny toolbar for cut/copy/paste

the desktop style will need the exact same thing
T10023

Test Plan

works correctly when in tablet mode, none of this is visible
when in desktop mode where the text fields behave normally

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Nov 12 2018, 4:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 12 2018, 4:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Nov 12 2018, 4:27 PM
mart edited the summary of this revision. (Show Details)Nov 12 2018, 4:27 PM

abetts added a subscriber: abetts.Nov 12 2018, 4:29 PM

Nice!

Is the popup themable?

mart edited the summary of this revision. (Show Details)Nov 12 2018, 4:29 PM

Nice!

Is the popup themable?

it uses whatever frame graphics the plasma theme uses
(note: this is only going to be used in plasmoids or plasma mobile, for desktop apps it will have to be implemented separatedly

Awesome!

I've always thought a "move" action for text would be nice on mobile. Traditional copy-paste is the kind of multi-step operation that's a lot more cumbersome to do with your fingers than it is with a keyboard.

mart added a comment.Nov 12 2018, 4:34 PM

Awesome!

I've always thought a "move" action for text would be nice on mobile. Traditional copy-paste is the kind of multi-step operation that's a lot more cumbersome to do with your fingers than it is with a keyboard.

i don't think we have the infrastructure for that (at least, assuming you mean that after pressing move one is presented with a gallery of widgets where to move it to)

I was thinking within the same text field.

bshah accepted this revision.Nov 12 2018, 4:44 PM
This revision is now accepted and ready to land.Nov 12 2018, 4:44 PM
mart added a comment.Nov 12 2018, 4:44 PM

I was thinking within the same text field.

hmm, usually on android i do copy/paste of text from different apps even.
like copying an url and paste on crome, or a query for google...

This revision was automatically updated to reflect the committed changes.