This patch ports away from the old PlacesItemEditDialog copy,
which doesn't honour the "applicationLocal" checkbox.
KFilePlaceEditDialog was not exported by KIO, but it will be starting
from 5.53
BUG: 376619
FIXED-IN: 19.03.80
Depends on D16825
Details
Details
- Reviewers
ngraham - Group Reviewers
Dolphin - Maniphest Tasks
- T9795: Use Places Panel code from KIO instead of private implementation
T8349: Improve Places panel usability and presentation - Commits
- R318:b5df5f4d9581: [PlacesPanel] Port to KFilePlaceEditDialog
- Create a new place ("Add Entry" from the panel context menu) and check the "only show in dolphin" checkbox
- Edit an existing (global) place and check the "only show in dolphin" checkbox
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
FIXED-IN: 19.03.80
Shouldn't that be 19.04.0? It doesn't matter that it will be in a future beta release; that's implied.
Also, something rather odd happens when I use the "Only show when using this application" checkbox from the new KFilePlacesEditDialog:
Not depicted in the video is the fact that any custom icon is reset, too.
Comment Actions
Well, not if the bug gets fixed after the beta was tagged. Then the fix would be in the RC (XX.YY.90) but not in the beta.