[PlacesPanel] Port to KFilePlaceEditDialog
ClosedPublic

Authored by elvisangelaccio on Nov 11 2018, 6:14 PM.

Details

Summary

This patch ports away from the old PlacesItemEditDialog copy,
which doesn't honour the "applicationLocal" checkbox.

KFilePlaceEditDialog was not exported by KIO, but it will be starting
from 5.53

BUG: 376619
FIXED-IN: 19.03.80

Depends on D16825

Test Plan
  • Create a new place ("Add Entry" from the panel context menu) and check the "only show in dolphin" checkbox
  • Edit an existing (global) place and check the "only show in dolphin" checkbox

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Dolphin. · View Herald TranscriptNov 11 2018, 6:14 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Nov 11 2018, 6:14 PM

FIXED-IN: 19.03.80

Shouldn't that be 19.04.0? It doesn't matter that it will be in a future beta release; that's implied.

Also, something rather odd happens when I use the "Only show when using this application" checkbox from the new KFilePlacesEditDialog:

Not depicted in the video is the fact that any custom icon is reset, too.

ngraham edited the summary of this revision. (Show Details)Nov 13 2018, 8:45 PM
  • Properly pass places' labels to the dialog

FIXED-IN: 19.03.80

Shouldn't that be 19.04.0? It doesn't matter that it will be in a future beta release; that's implied.

Well, not if the bug gets fixed after the beta was tagged. Then the fix would be in the RC (XX.YY.90) but not in the beta.

ngraham accepted this revision.Nov 20 2018, 12:08 AM

Thanks, that fixed it. Everything else seems to work too.

This revision is now accepted and ready to land.Nov 20 2018, 12:08 AM
This revision was automatically updated to reflect the committed changes.