Details
- Reviewers
yurchor ngraham - Group Reviewers
VDG Localization
Diff Detail
- Repository
- R108 KWin
- Branch
- master
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 4712 Build 4730: arc lint + arc unit
Please clarify with the translation teams that they agree on the need of these changes. Such seemingly harmless fixups cause quite some work for translation teams.
| scripts/minimizeall/metadata.desktop | ||
|---|---|---|
| 2 ↗ | (On Diff #45094) | This is a name. We need to assume that the author intended it to be like that and not gramatically correct. E.g. it's also incorrectly Okular. |
Whoops, my mistake! Fixed the 'MinimizeAll' issue.
Regarding the clarification with the translation teams, are you just referring to the 'MinimizeAll' change or to all of the changes?
Thanks!
All of the changes. It's just that a minor change means that each translation team has to look at it. So this creates lots of work. I normally always considered it not worth to do such changes given the amount of additional work it causes for other teams.
I understand, I will reach out to the translation team to see what they think.
Would keeping the changes which ONLY fix capitalization be acceptable in the meantime?
Please first clarify. If you change anything it ends up as a new string to translate for the teams. So it doesn't matter how minor a change it, every change means the translation teams need to look at it.
No objections if this will make the style consistent.
If it is in accordance with the HIG rules this should be done sooner or later anyway. BTW no need to change en_GB, as it will be overwritten by scripty anyway.
// One of the translation teams coordinators (uk)
IMHO it generally makes sense to improve strings--as long as they are genuine improvements!
I'm okay with some of these changes but am increasingly unsure that changing the "Comment" fields on the desktop files is a good idea. That field determines the largest string on the page that looks like its effective title. However semantically it's not the title; it's really more of a caption. But its size and position makes it look like a title and the result is a little odd:
I think it would be worth putting some thought into coming up with an improved visual design that gives less prominence to the Comment so that it doesn't look like a title and feel inconsistent with the other displayed title-like strings in the UI. Once we do that, then changing the capitalization may not be necessary since the comment would return to its proper place as a simple caption which probably doesn't need to be in Title Case.
| kcmkwin/kwindecoration/kwindecoration.desktop | ||
|---|---|---|
| 83 | Revert this change; it happens automatically. | |
| 116 | Revert this change; it happens automatically. | |
| kcmkwin/kwinscreenedges/kwintouchscreen.desktop | ||
| 56 | Revert this change; it happens automatically. | |
| 83 | Revert this change; it happens automatically. | |
| kcmkwin/kwinscripts/kwinscripts.desktop | ||
| 121 | Revert this change; it happens automatically. | |
| 159 | Revert this change; it happens automatically. | |
| kcmkwin/kwintabbox/kwintabbox.desktop | ||
| 81 | Revert this change; it happens automatically. | |
| 113 | Revert this change; it happens automatically. | |
| keyboard_layout.cpp | ||
|---|---|---|
| 196 | Have you tested this? Because you're breaking things with this change. Yes the code is incredibly fragile, but i've no idea why you decided to change this given this is not a user visible string. | |