Updated with petroleum industry units
AbandonedPublic
Actions

Authored by joaonetto on Nov 5 2018, 12:59 PM.

Details

Reviewers

ngraham
broulik

Group Reviewers

Frameworks

Summary

Added a new volume unity Oil Barrels and a new permeability class that handles Darcy and MiliDarcys.

BUG 388074

Diff Detail

Repository

R292 KUnitConversion

Branch

permeability (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4587
Build 4605: arc lint + arc unit

joaonetto created this revision.Nov 5 2018, 12:59 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptNov 5 2018, 12:59 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

joaonetto requested review of this revision.Nov 5 2018, 12:59 PM

Harbormaster completed remote builds in B4585: Diff 44899.Nov 5 2018, 12:59 PM

Updating D16681: Updated with petroleum industry units

Harbormaster completed remote builds in B4587: Diff 44901.Nov 5 2018, 1:16 PM

joaonetto edited the summary of this revision. (Show Details)Nov 5 2018, 1:18 PM

Great job, and nice first patch!

Unfortunately, this doesn't compile:

-- Configuring done
CMake Error at src/CMakeLists.txt:32 (add_library):
  Cannot find source file:

    permeability.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
  .hxx .in .txx

Looks like the new permeability files weren't added to the patch. You can use git add <path to permeability.h> <path to permeability.cpp> to do so, then arc diff to update the diff.