Differential D16678

Fix root disk icon change so that it doesn't erroneously change other icons
ClosedPublic
Actions

Authored by ngraham on Nov 5 2018, 4:46 AM.

Details

Reviewers
bruns
broulik
davidedmundson
Commits
R245:6d0f74132fcd: Fix root disk icon change so that it doesn't erroneously change other icons
Summary

I committed D16653 too soon without enough testing, because it had the effect of applying the default drive-harddisk icon to more device types. Oops. Sorry about that. :(

This patch fixes the problem, and is better tested.

Test Plan

Other device types are not affected:

Diff Detail

Repository
R245 Solid
Branch
fix-root-icon-change (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4576
Build 4594: arc lint + arc unit
ngraham created this revision.Nov 5 2018, 4:46 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 5 2018, 4:46 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Nov 5 2018, 4:46 AM
ngraham edited the test plan for this revision. (Show Details)Nov 5 2018, 4:46 AM
broulik added inline comments.Nov 5 2018, 4:52 AM
src/solid/devices/backends/udisks2/udisksdevice.cpp
874

Can you check whether using isStorageAccess() is more desirable/performant?

src/solid/devices/backends/udisks2/udisksdevice.h
84

This isn't public API, you don't need this comment, also perhaps isRootVolume

ngraham updated this revision to Diff 44883.Nov 5 2018, 4:55 AM

Address review comments

ngraham marked 2 inline comments as done.Nov 5 2018, 4:56 AM
ngraham updated this revision to Diff 44884.Nov 5 2018, 4:59 AM

Use isStorageAccess() rather than isStorageVolume()

broulik accepted this revision.Nov 5 2018, 5:25 AM
This revision is now accepted and ready to land.Nov 5 2018, 5:25 AM
Closed by commit R245:6d0f74132fcd: Fix root disk icon change so that it doesn't erroneously change other icons (authored by ngraham). · Explain WhyNov 5 2018, 11:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44883

View Options

src/solid/devices/backends/udisks2/udisksdevice.h

Loading...
View Options

src/solid/devices/backends/udisks2/udisksdevice.cpp

Loading...