[server] Put set surrounding text callback with uint in v0 class
ClosedPublic
Actions

Authored by romangg on Nov 4 2018, 10:38 PM.

Details

Reviewers

Group Reviewers

KWin
Frameworks

Commits

R127:c3179f58e248: [server] Put set surrounding text callback with uint in v0 class

Summary

The set surrounding text request is only in v0 of text-input with uint arguments,
in v2 and v3 the call has the same signature.

To increase readability put the uint version in the v0 class implementation
and rename callbacks.

Test Plan

Compiles

Diff Detail

Repository

R127 KWayland

Branch

textInputSurroundingTextCallback

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 4570
Build 4588: arc lint + arc unit

romangg created this revision.Nov 4 2018, 10:38 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptNov 4 2018, 10:38 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

romangg requested review of this revision.Nov 4 2018, 10:38 PM

Harbormaster completed remote builds in B4570: Diff 44874.Nov 4 2018, 10:38 PM

romangg retitled this revision from [server] Set surrounding text callback with uint in v0 class to [server] Put set surrounding text callback with uint in v0 class.Nov 4 2018, 10:39 PM

Could the renaming be problematic in regards to binary compatibility? All are private interfaces though.

romangg added a dependent revision: D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes.Nov 5 2018, 1:33 AM

In D16675#354181, @romangg wrote:

Could the renaming be problematic in regards to binary compatibility? All are private interfaces though.

I don't think so. Otherwise PIMPL is pointless.

zzag accepted this revision.Nov 6 2018, 11:47 AM

This revision is now accepted and ready to land.Nov 6 2018, 11:47 AM

Could the renaming be problematic in regards to binary compatibility

It's fine here.

As a general rule, if the class isn't defined in an installed header you can do whatever.

Closed by commit R127:c3179f58e248: [server] Put set surrounding text callback with uint in v0 class (authored by romangg). · Explain WhyNov 6 2018, 12:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/server/textinput_interface.cpp (7 lines)
M			src/server/textinput_interface_p.h (3 lines)
M			src/server/textinput_interface_v0.cpp (8 lines)
M			src/server/textinput_interface_v2.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44874	be0ad76		Nov 4 2018, 10:38 PM	★	★
Diff 2	44962	c10f95d	R127:c3179f58e248efb9796b38e8269626a7690e779d	Nov 6 2018, 12:49 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
531f8ec8dfa8	346a61cd274d	be0ad76729b6	Roman Gilg	[server] Set surrounding text callback with uint in v0 class (Show More…)	Nov 4 2018, 10:32 PM

	Status	Author	Revision
	Closed	romangg	D16676 [server] Put text-input (de-)activate, en-/disable callbacks in child classes
	Closed	romangg	D16675 [server] Put set surrounding text callback with uint in v0 class