[server] Put set surrounding text callback with uint in v0 class
ClosedPublic

Authored by romangg on Nov 4 2018, 10:38 PM.

Details

Summary

The set surrounding text request is only in v0 of text-input with uint arguments,
in v2 and v3 the call has the same signature.

To increase readability put the uint version in the v0 class implementation
and rename callbacks.

Test Plan

Compiles

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Nov 4 2018, 10:38 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 4 2018, 10:38 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
romangg requested review of this revision.Nov 4 2018, 10:38 PM
romangg retitled this revision from [server] Set surrounding text callback with uint in v0 class to [server] Put set surrounding text callback with uint in v0 class.Nov 4 2018, 10:39 PM

Could the renaming be problematic in regards to binary compatibility? All are private interfaces though.

zzag added a subscriber: zzag.Nov 6 2018, 11:40 AM

Could the renaming be problematic in regards to binary compatibility? All are private interfaces though.

I don't think so. Otherwise PIMPL is pointless.

zzag accepted this revision.Nov 6 2018, 11:47 AM
This revision is now accepted and ready to land.Nov 6 2018, 11:47 AM

Could the renaming be problematic in regards to binary compatibility

It's fine here.

As a general rule, if the class isn't defined in an installed header you can do whatever.

This revision was automatically updated to reflect the committed changes.