In kparts mode we just want to show the TerminalDisplay,
but right now this is very hard, so just hide the tabbar.
Details
Details
- Reviewers
hindenburg sandsmark ngraham
Opened instances of dolphin / kate and looked the kparts output.
Opened konsole, everything seems fine.
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Branch
- fixTabKParts
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4563 Build 4581: arc lint + arc unit
Comment Actions
Did you consider just checking isKonsolePart() and hiding the tabbar? I didn't actually try coding that but since other parts of the code use thought it was a possibility.
Comment Actions
I didn't, I looked for isPart, isKPart but my grep didn't try
isKonsokePart. I'll update the code.
Em ter, 6 de nov de 2018 às 02:28, Kurt Hindenburg <
noreply@phabricator.kde.org> escreveu:
hindenburg added a comment. View Revision
https://phabricator.kde.org/D16669Did you consider just checking isKonsolePart() and hiding the tabbar? I
didn't actually try coding that but since other parts of the code use
thought it was a possibility.*REPOSITORY*
R319 Konsole*REVISION DETAIL*
https://phabricator.kde.org/D16669*To: *tcanabrava, hindenburg, sandsmark, ngraham
*Cc: *konsole-devel, ngraham, maximilianocuria, hindenburg