Differential D16706

Hide tabbar in KParts
ClosedPublic
Actions

Authored by tcanabrava on Nov 6 2018, 12:21 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:996c4a4c18b9: Hide tabbar in KParts
Summary

After QTabBar revamp, correct issue where tabs were still
showing in KParts.

Test Plan

Opened instances of dolphin / kate and looked the kparts output.
Opened konsole, everything seems fine.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Nov 6 2018, 12:21 PM
Restricted Application added a project: Konsole. · View Herald TranscriptNov 6 2018, 12:21 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Nov 6 2018, 12:21 PM
tcanabrava edited the summary of this revision. (Show Details)Nov 6 2018, 12:22 PM
tcanabrava added a reviewer: hindenburg.
hindenburg edited the summary of this revision. (Show Details)Nov 6 2018, 2:52 PM
hindenburg edited the test plan for this revision. (Show Details)
hindenburg added a reviewer: Konsole.
hindenburg added a comment.Nov 6 2018, 3:00 PM

Thanks, I was hoping it would be this simple.

hindenburg accepted this revision.Nov 7 2018, 1:31 AM
This revision is now accepted and ready to land.Nov 7 2018, 1:31 AM
Closed by commit R319:996c4a4c18b9: Hide tabbar in KParts (authored by tcanabrava, committed by hindenburg). · Explain WhyNov 7 2018, 1:31 AM
This revision was automatically updated to reflect the committed changes.
hindenburg added a comment.Nov 22 2018, 3:29 AM

This throws ASAN errors

ViewContainer.cpp:175:28: runtime error: member call on null pointer of type 'Konsole::SessionController'

SessionController.cpp:1778:25: runtime error: member call on null pointer of type 'const Konsole::SessionController *'

SUMMARY: UndefinedBehaviorSanitizer: undefined-behaviorSessionController.cpp:1778:25

tcanabrava added a comment.Nov 23 2018, 8:40 AM
Well, the code that got in qApp->applicationName() == "konsole" shouldn't be part of a class, it's a perfectly valid function. this would fix everything. I'll prepare a patch for this later.
Revision Contents
Changeset List
PathPackages
Msrc/ViewContainer.cpp (20 lines)
Diff 44999
View Options
src/ViewContainer.cpp
Loading...