At least in the benchmark, QXmlStreamReader is more than twice as fast
as QDomDocument.
Details
Details
- Reviewers
astippich apol - Group Reviewers
Frameworks - Commits
- R286:3129ba1798fd: [XmlExtractor] Use QXmlStreamReader for better performance
Before/after:
RESULT : XmlExtractorTests::benchMarkXmlExtractor():
810 msecs per iteration (total: 810, iterations: 1)
RESULT : XmlExtractorTests::benchMarkXmlExtractor():
288 msecs per iteration (total: 288, iterations: 1)
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| autotests/xmlextractortest.cpp | ||
|---|---|---|
| 70 | why is there a difference? | |
| autotests/xmlextractortest.cpp | ||
|---|---|---|
| 70 | QDomElement::text() leaves a final trailing whitespace which is not trimmed. | |
Comment Actions
Patch looks good overall +1
| autotests/xmlextractortest.cpp | ||
|---|---|---|
| 70 | Won't this break any use? | |
| autotests/xmlextractortest.cpp | ||
|---|---|---|
| 70 | Previously, the last element was "foo_bar__", now it is "foo_bar_". | |